aaron.ballman added inline comments.
================ Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:332 << "()->getName() : \"\") << \""; + else if (type == "VarDecl *") + OS << "\" << get" << getUpperName() << "()->getName() << \""; ---------------- I think this change is good, but if you wouldn't mind adding an ast dumping test (in the AST test directory) that exercises the change, I'd appreciate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits