steakhal added inline comments.
================ Comment at: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp:19 +#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h" +#include "llvm/Config/config.h" +#include "gtest/gtest.h" ---------------- steakhal wrote: > whisperity wrote: > > steakhal wrote: > > > mgorny wrote: > > > > `config.h` is a private LLVM header and must not be used from clang. > > > I'm not a CMake profession, but shouldn't it be declared private to the > > > LLVM target in the corresponding CMakeLists file then? > > > > > > How do you query whether clang has built with Z3 or not @mgorny? > > > I'm including that header only for that. > > I've did a quick skim of the code, and it seems there is no way in it > > currently to query this. > > Your best bet would be either adding an extra flag to Clang's CMake > > generated Config header that inherits this flag, or checking > > `llvm::CreateZ3Solver()` - right now, this method reports a fatal error, > > but you could create a bool function in the header which reports constant > > true or false, and turn the test's skip into a runtime condition? > How could I use a //private// header in the first place? The fix is on the way: D84929 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78704/new/ https://reviews.llvm.org/D78704 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
