lei accepted this revision. lei added a comment. This revision is now accepted and ready to land.
LGTM, Please add tests for BE in llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll prior to committing. ================ Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \ +; RUN: -mcpu=pwr10 -ppc-asm-full-reg-names -ppc-vsr-nums-as-vr < %s | \ ---------------- stefanp wrote: > NeHuang wrote: > > Do we also need to run for big endian? > I don't think it would hurt to add a BE run for this as well. the only thing > to watch out for is the fact that this is not actually a new file. This test > file already exists on master so I assume that this will be merged in (and > not added as a new file). I believe this is a new file 🙂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82467/new/ https://reviews.llvm.org/D82467 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
