etienneb added a comment. more nits, sorry didn't saw them first time.
================ Comment at: test/clang-tidy/cppcoreguidelines-interfaces-global-init.cpp:32 @@ +31,3 @@ +// CHECK-MESSAGES: [[@LINE-1]]:12: warning: initializing static variable with non-const expression depending on static variable 'ClassScope' +} // namspace ns + ---------------- nit: namspace -> namespace ================ Comment at: test/clang-tidy/cppcoreguidelines-interfaces-global-init.cpp:43 @@ +42,3 @@ +static int GlobalScope2 = takesInt(ns::NamespaceScope); + +// Enums are fine. ---------------- nit: remove empty line here. http://reviews.llvm.org/D18649 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
