pzheng marked 2 inline comments as done. pzheng added a comment. In D83648#2146606 <https://reviews.llvm.org/D83648#2146606>, @MaskRay wrote:
> Created http://lists.llvm.org/pipermail/cfe-dev/2020-July/066245.html > [cfe-dev] Usage of clang::driver::options::DriverOption (-Xarch_ & gcc > toolchain) > to ask about the use case. > > When I get time, I'll work on a patch fixing the whole class of options > instead of just -fintegrated-as. I will use `OPT_Link_Group` and add some > extra options in the new group: `GCCLinkOption`. Sounds like I should remove the test from this patch since you will fix a class of options later? ================ Comment at: clang/test/Driver/integrated-as.c:10 +// RUN: %clang -### -fintegrated-as %s 2>&1 | FileCheck %s -check-prefix FIAS-LINK + ---------------- MaskRay wrote: > MaskRay wrote: > > This test is incorrect. You need a specific target triple to select > > bare-metal like GCC driver. > There are so many clang specific options. I think we just need a centralized > test file to test options in patch, instead of adding random `-NOT` check > lines to random files. Thanks for pointing this out. Will update the triple. ================ Comment at: clang/test/Driver/integrated-as.c:10 +// RUN: %clang -### -fintegrated-as %s 2>&1 | FileCheck %s -check-prefix FIAS-LINK + ---------------- pzheng wrote: > MaskRay wrote: > > MaskRay wrote: > > > This test is incorrect. You need a specific target triple to select > > > bare-metal like GCC driver. > > There are so many clang specific options. I think we just need a > > centralized test file to test options in patch, instead of adding random > > `-NOT` check lines to random files. > Thanks for pointing this out. Will update the triple. Can you suggest a file to add the test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83648/new/ https://reviews.llvm.org/D83648 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
