lenary added a comment.
Thanks for the fix!
Please can you also update `clang/test/Misc/target-invalid-cpu-note.c` for
riscv32 and riscv64 - it's likely you'll need the fix in the inline note below.
Also, there are a bunch of clang-tidy issues, which I think we can fix now
rather than later.
================
Comment at: llvm/lib/Support/TargetParser.cpp:250
+ for (const auto &C : RISCVCPUInfo) {
+ if (IsRV64 == C.Is64Bit())
+ Values.emplace_back(C.Name);
----------------
This line should be `if (C.Kind != CK_INVALID && IsRV64 == C.Is64Bit())` so
that when clang prints out valid CPUs, 'invalid' is not included in the list.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71124/new/
https://reviews.llvm.org/D71124
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
