JonChesterfield added inline comments.
================ Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.cpp:39 + // return constant compile-time target-specific warp size + unsigned WarpSize = CGF.getTarget().getGridValue(llvm::omp::GV_Warp_Size); + return Bld.getInt32(WarpSize); ---------------- ABataev wrote: > This is new functionality, better to move it in a separate patch, and this > one mark as NFC. Works for me. This patch shows how the per-target parts are intended to be done. First patch being totally NFC seems good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83723/new/ https://reviews.llvm.org/D83723 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
