hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added a comment.
LGTM with minor nit.
================
Comment at: clang/lib/Driver/Driver.cpp:478
+ // On AIX, the env OBJECT_MODE may affect the resulting arch variant.
+ if (Target.isOSAIX()) {
+ if (Optional<std::string> ObjectModeValue =
----------------
Just a note: I guess having an AIX target is an okay proxy for being on AIX
here... I don't think enabling `OBJECT_MODE` for other targets when building on
AIX is superior.
================
Comment at: clang/test/Driver/aix-object-mode.c:1
+// Check setting an OBJECT_MODE converts the AIX triple to the right variant.
+// RUN: env OBJECT_MODE=64 \
----------------
Minor nit: Add "that" between "Check" and "setting".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82476/new/
https://reviews.llvm.org/D82476
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
