greened marked an inline comment as done.
greened added inline comments.
================
Comment at: llvm/utils/update_cc_test_checks.py:133
+ parser.add_argument('--include-generated-funcs', action='store_true',
+ help='Output checks for functions not in source')
parser.add_argument('tests', nargs='+')
----------------
jdoerfert wrote:
> I think this should go into common.py (after D78618). I would also make this
> the default but OK.
Yes I suppose it should in case `opt` and friends generate functions. I hadn't
considered that use-case.
While I would like to make it default unfortunately it would require updating a
bunch of the existing clang tests which doesn't seem too friendly. See the
patch update comment for details.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83004/new/
https://reviews.llvm.org/D83004
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
