njames93 added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:121
"bugprone-narrowing-conversions");
+ CheckFactories.registerCheck<NoEscapeCheck>("bugprone-no-escape");
CheckFactories.registerCheck<NotNullTerminatedResultCheck>(
----------------
aaron.ballman wrote:
> Given that this is limited to Objective-C, why register this under `bugprone`
> as opposed to the `objc` module? Alternatively, why limit to Objective-C when
> blocks can be used in other modes like C or C++ with `-fblocks`?
Thats a good point, maybe restrict this to `LangOptions::ObjC ||
LangOptions::Blocks` Then it can be left in bugprone.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82904/new/
https://reviews.llvm.org/D82904
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
