rsmith added inline comments. ================ Comment at: test/PCH/arm-__va_list_tag.c:1-7 @@ +1,8 @@ +// REQUIRES: arm-registered-target + +// This test checks the patch for the compilation error / crash described in the D18557. + +// Test as a C source +// RUN: %clang_cc1 -triple=armv7-linux-gnueabihf -emit-pch -x c-header -o %t %S/Inputs/arm-__va_list_tag.h +// RUN: %clang_cc1 -triple=armv7-linux-gnueabihf -fsyntax-only -include-pch %t %s + ---------------- Can we remove the triple from this test, and instead test it on the default target for each bot? That should give us broader coverage, and let us find out if the same bug exists for other targets too.
Repository: rL LLVM http://reviews.llvm.org/D18557 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits