sammccall accepted this revision. sammccall added a subscriber: erichkeane. sammccall added a comment. This revision is now accepted and ready to land.
Existing logic is odd. Error propagation change is definitely correct, and I suspect the other change is too, but let's ask just in case. (The whole DependentIntExtType landed after the dependence refactoring, so this wasn't something we mangled in the refactoring) ================ Comment at: clang/lib/AST/Type.cpp:356 - : TypeDependence::None) | - (NumBitsExpr->containsUnexpandedParameterPack() - ? TypeDependence::VariablyModified ---------------- @erichkeane was there any intent behind translating "num bits contains unexpanded pack" into "extint is variably modified", or was this an oversight? (My guess is the latter, just want to double check) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83114/new/ https://reviews.llvm.org/D83114 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
