dmajor added a comment.

In D65543#2122942 <https://reviews.llvm.org/D65543#2122942>, @dmajor wrote:

> After this change, PGO builds of clang on Windows can no longer find 
> `clang_rt.profile-x86_64.lib`. Is there some cmake magic that could 
> potentially make this seamless? Or is it expected that the burden is on the 
> user to set up the paths manually during the `LLVM_BUILD_INSTRUMENTED` phase?


Err, it looks like this commit already has exactly such cmake magic!

In that case, more specifically, the problem I'm seeing is that these flags are 
not making it through to a small handful of files: LLVMHello.dll, 
PrintFunctionNames.dll, AnnotateFunctions.dll, Attribute.dll. Let me dig in a 
little deeper...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65543/new/

https://reviews.llvm.org/D65543



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to