aaron.ballman added inline comments.
================
Comment at:
clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193
if (checkConditionVarUsageInElse(If) != nullptr) {
+ if (!WarnOnConditionVariables)
+ return;
----------------
Would it make sense to hoist this into the previous `if` statement so we don't
bother checking the condition var use in the first place if we're just going to
ignore the results?
================
Comment at:
clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:228
if (checkInitDeclUsageInElse(If) != nullptr) {
+ if (!WarnOnConditionVariables)
+ return;
----------------
Same here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82824/new/
https://reviews.llvm.org/D82824
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
