ABataev added inline comments.
================ Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7893-7897 + llvm::errs() << "DEBUG in CGOpenMPRuntime.cpp\n"; + OASE->getLowerBound()->dump(); + OASE->getLength()->dump(); + OASE->getStride()->dump(); + ---------------- Must be removed ================ Comment at: clang/lib/Sema/SemaExpr.cpp:4907 + if (Stride) { + auto Res = + PerformOpenMPImplicitIntegerConversion(Stride->getExprLoc(), Stride); ---------------- `auto`->`ExprResult` ================ Comment at: clang/test/OpenMP/target_update_ast_print.cpp:66 +#pragma omp target update from(marr [1:1:1] [0:2:] [1:0]) + ---------------- It would be good to add some positive tests for other constructs, like `target`, `target data` etc., if allowed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits