kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
LGTM, thanks! This was also my final plan after investigating in https://reviews.llvm.org/D81920, but then I forgot ... ================ Comment at: clang/CMakeLists.txt:398 + if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang") + # Clang's version of -Woverloaded-virtual is OK, GCC's is too noisy. + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Woverloaded-virtual") ---------------- nit: maybe put the gnu bug link in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82617/new/ https://reviews.llvm.org/D82617 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
