fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land.
LGTM, thank you! ================ Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1-bfloat.c:4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -triple aarch64-none-linux-gnu -target-feature +sve -target-feature +bf16 -fallow-half-arguments-and-returns -fsyntax-only -verify -verify-ignore-unexpected=error -verify-ignore-unexpected=note %s + +#include <arm_sve.h> ---------------- kmclaughlin wrote: > fpetrogalli wrote: > > Nit: is it worth adding the `ASM-NOT: warning` check that is used in other > > tests? Of course, only if it doesn't fail, for in such case we would have > > to address the problem in a separate patch. > > > > (Same for all the new C tests added in this patch). > Adding the check doesn't fail, but I will add these checks to the load & > store tests in a separate patch Yep - thanks for confirming. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82448/new/ https://reviews.llvm.org/D82448 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
