sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/Hover.cpp:345 + if (E->isValueDependent() || !E->EvaluateAsRValue(Constant, Ctx) || + // Disable printing for tag-types, as they are usually confusing and might + // make clang crash while printing the expressions. ---------------- nit: tag -> record (not handling enums) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82326/new/ https://reviews.llvm.org/D82326 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
