sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2430 + if (BaseType->containsErrors()) { + // FIXME: should we emit a diagnostic here? We already emit a diagnostic + // when parsing the error type. ---------------- I think this is fine, just "// already emitted this error" or so Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82086/new/ https://reviews.llvm.org/D82086 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits