kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
Thanks LGTM! ================ Comment at: clang-tools-extra/clangd/index/Background.h:140 + // In production an explicit value is passed. + size_t ThreadPoolSize = 4, std::function<void(BackgroundQueue::Stats)> OnProgress = nullptr); ---------------- maybe `ClangdServer::optsForTest().AsyncThreadsCount` instead of hardcoding 4 in another place ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82352/new/ https://reviews.llvm.org/D82352 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits