[PATCH] D82346: [WebAssebmly] Fully disable 'protected' visibility

[Sam Clegg via Phabricator via cfe-commits]

sbc100 created this revision.
Herald added subscribers: cfe-commits, aheejin, jgravelle-google, dschuff.
Herald added a project: clang.
sbc100 added a reviewer: dschuff.

Emscripten doesn't use protected visibility either.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82346

Files:
  clang/lib/Basic/Targets/WebAssembly.h


Index: clang/lib/Basic/Targets/WebAssembly.h
===================================================================
--- clang/lib/Basic/Targets/WebAssembly.h
+++ clang/lib/Basic/Targets/WebAssembly.h
@@ -133,11 +133,7 @@
 
   bool hasExtIntType() const override { return true; }
 
-  bool hasProtectedVisibility() const override {
-    // TODO: For now, continue to advertise "protected" support for
-    // Emscripten targets.
-    return getTriple().isOSEmscripten();
-  }
+  bool hasProtectedVisibility() const override { return false; }
 };
 
 class LLVM_LIBRARY_VISIBILITY WebAssembly32TargetInfo



Index: clang/lib/Basic/Targets/WebAssembly.h
===================================================================
--- clang/lib/Basic/Targets/WebAssembly.h
+++ clang/lib/Basic/Targets/WebAssembly.h
@@ -133,11 +133,7 @@
 
   bool hasExtIntType() const override { return true; }
 
-  bool hasProtectedVisibility() const override {
-    // TODO: For now, continue to advertise "protected" support for
-    // Emscripten targets.
-    return getTriple().isOSEmscripten();
-  }
+  bool hasProtectedVisibility() const override { return false; }
 };
 
 class LLVM_LIBRARY_VISIBILITY WebAssembly32TargetInfo

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits