dschuff added a comment.
So the code LGTM, were you going to add to usertest.ll in this CL?
================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp:84
WasmSym->setGlobalType(wasm::WasmGlobalType{
- uint8_t(Subtarget.hasAddr64() ? wasm::WASM_TYPE_I64
- : wasm::WASM_TYPE_I32),
+ uint8_t(Subtarget.hasAddr64() && strcmp(Name, "__table_base") != 0
+ ? wasm::WASM_TYPE_I64
----------------
aardappel wrote:
> dschuff wrote:
> > should __table_base stay as i32?
> I'd think so, right? since it refers to table indices, not memory
Oh, right; I'd misread this as setting it just for table_base but I had it
backwards; it's exempting table_base. So yeah this is right.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82130/new/
https://reviews.llvm.org/D82130
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
