steveire added inline comments.
================ Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:2618 + )"; + EXPECT_TRUE(matches(kTest, expr(nullPointerConstant()))); } ---------------- While this test in ASTMatchers might continue to make sense, shouldn't there be a test in `clang/unittests/AST` for this API? `isNullPointerConstant` seems to be complicated. Does it have a unit test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82279/new/ https://reviews.llvm.org/D82279 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
