zbrid added inline comments.
================ Comment at: llvm/lib/Target/X86/X86SpeculativeExecutionSideEffectSuppression.cpp:90 + const X86Subtarget &Subtarget = MF.getSubtarget<X86Subtarget>(); + if (!Subtarget.useSpeculativeExecutionSideEffectSuppression() && + !EnableSpeculativeExecutionSideEffectSuppression) ---------------- zbrid wrote: > sconstab wrote: > > Is it really necessary to have the target feature and the CLI flag? If > > SESES is required for, say, a *.ll file, then `+seses` can always be added > > as a target feature. > I think there should be a way to turn on SESES without lvi-cfi. Similar to > how there are flags to turn on SLH in various configurations. I'll see if I > can lower the number of flags while still enabling that possibility. Ah I think I'll change the SESES-only flag to enable-without-lvi-cfi, so it's more explicit it's missing functionality/security. Updates will come soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
