fpetrogalli added inline comments.
================
Comment at: clang/include/clang/Basic/arm_sve.td:1115
+let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in {
+def SVREV_BF16 : SInst<"svrev[_{d}]", "dd", "b", MergeNone,
"aarch64_sve_rev">;
----------------
nit: could create a multiclass here like @sdesmalen have done in
https://reviews.llvm.org/D82187, seems quite a nice way to keep the definition
of the intrinsics together (look for `multiclass StructLoad`, for example)
================
Comment at: clang/include/clang/Basic/arm_sve.td:1298
+let ArchGuard = "defined(__ARM_FEATURE_SVE_MATMUL_FP64) &&
defined(__ARM_FEATURE_SVE_BF16)" in {
+def SVTRN1Q_BF16 : SInst<"svtrn1q[_{d}]", "ddd", "b", MergeNone,
"aarch64_sve_trn1q">;
----------------
Same here, could use a multiclass to merge the "regular" intrinsics definition
with the BF ones.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82182/new/
https://reviews.llvm.org/D82182
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
