NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
Ok then! ================ Comment at: clang/utils/analyzer/entrypoint.py:31 + +CMAKE_COMMAND = "cmake -G Ninja -DCMAKE_BUILD_TYPE=Release " \ + "-DCMAKE_INSTALL_PREFIX=/analyzer -DLLVM_TARGETS_TO_BUILD=X86 " \ ---------------- vsavchenko wrote: > NoQ wrote: > > `-DLLVM_ENABLE_ASSERTIONS=ON`??? > I was thinking about adding a separate list of options specifically for > building. Assertions can significantly affect performance and I don't know > if that should be a default. I still think assertions should be on by default; it's much worse when somebody accidentally tests a logic-related patch without assertions than when somebody tests a performance-related patch with assertions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81571/new/ https://reviews.llvm.org/D81571 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
