jhenderson added a comment. In D81672#2101513 <https://reviews.llvm.org/D81672#2101513>, @aganea wrote:
> But that won't work when compiling & crashing with `-fno-integrated-cc1`, > would it? (or if building with `cmake ... -DCLANG_SPAWN_CC1=1`). In that > case, normal crashes (not -gen-reproducer) won't go through the > `CrashRecoveryContext`. > Try running: > > $ CCC_OVERRIDE_OPTIONS=+-fno-integrated-cc1 > $ py your_build_folder/bin/llvm-lit.py -vv -a > clang/test/Driver/crash-report.c > > > See if the commands issued by the test display the "PLEASE submit a bug > report" message. If I'm following it correctly (I could easily not be), the latest version of the patch will also no longer print the bug report submission message for crashes in other parts of LLVM, not just clang, which was rather the motivation of @gbreynoo's recent changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
