steven.zhang added inline comments.
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14069 + BuiltinID == PPC::BI__builtin_vsx_xvrspim) + ID = Intrinsic::floor; + else if (BuiltinID == PPC::BI__builtin_vsx_xvrdpi || ---------------- Can we do it like this to avoid the duplicate if statement ? ``` if (...) ID = Builder.getIsFPConstrained() ? Intrinsic::experimental_constrained_floor : Intrinsic::floor; ... return Builder.getIsFPConstrained() ? Builder. CreateConstrainedFPCall() : Builder.CreateCall(); ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82020/new/ https://reviews.llvm.org/D82020 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
