sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:252 TEST(ParsedASTTest, CanBuildInvocationWithUnknownArgs) { MockFSProvider FSProvider; FSProvider.Files = {{testPath("foo.cpp"), "void test() {}"}}; ---------------- These are still FSProvider... would suggest MockFS FS ================ Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:23 ParseInputs TestTU::inputs(MockFSProvider &FSProvider) const { std::string FullFilename = testPath(Filename), ---------------- Still seem to be a few FSProviders here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82024/new/ https://reviews.llvm.org/D82024 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits