kadircet added inline comments.

================
Comment at: clang-tools-extra/clangd/Preamble.h:136
   std::vector<Inclusion> PreambleIncludes;
+  PreambleBounds PatchBounds = {0, false};
 };
----------------
sammccall wrote:
> nit: = {} seems less confusing.
> 
> Call this ModifiedBounds (or ModifiedPreambleBounds) as well? Not obvious to 
> me what it is at the moment.
unfortunately `PreambleBounds` doesn't have a default constructor :/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81964/new/

https://reviews.llvm.org/D81964



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to