hubert.reinterpretcast added inline comments.
================
Comment at: clang/include/clang/Basic/TargetInfo.h:1389
+ /// Whether target supports the special power alignment rules of AIX.
+ virtual bool supportsAIXPowerAlignment() const { return false; }
----------------
Minor nit: Use backquotes around the XL option value "power".
================
Comment at: clang/lib/AST/ASTContext.cpp:2415
// Double and long long should be naturally aligned if possible.
if (const auto *CT = T->getAs<ComplexType>())
----------------
Comment should be updated.
================
Comment at: clang/lib/AST/ASTContext.cpp:2424
+ (T->isSpecificBuiltinType(BuiltinType::LongDouble) &&
+ Target->supportsAIXPowerAlignment()))
// Don't increase the alignment if an alignment attribute was specified on
a
----------------
Does `supportsAIXPowerAlignment` express the condition we want to check here?
That might be true for an implementation operating with `mac68k` alignment
rules.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79719/new/
https://reviews.llvm.org/D79719
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
