Author: Haojian Wu Date: 2020-06-15T11:26:32+02:00 New Revision: 1e87261ba17c8e8e615d4b59d46ca04996b62977
URL: https://github.com/llvm/llvm-project/commit/1e87261ba17c8e8e615d4b59d46ca04996b62977 DIFF: https://github.com/llvm/llvm-project/commit/1e87261ba17c8e8e615d4b59d46ca04996b62977.diff LOG: [clangd] Turn on RecoveryAST for clangd by default. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D81739 Added: Modified: clang-tools-extra/clangd/ClangdServer.h clang-tools-extra/clangd/tool/ClangdMain.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/ClangdServer.h b/clang-tools-extra/clangd/ClangdServer.h index 2c477faecedd..b758a5f32aa7 100644 --- a/clang-tools-extra/clangd/ClangdServer.h +++ b/clang-tools-extra/clangd/ClangdServer.h @@ -121,7 +121,7 @@ class ClangdServer { ClangTidyOptionsBuilder GetClangTidyOptions; /// If true, turn on the `-frecovery-ast` clang flag. - bool BuildRecoveryAST = false; + bool BuildRecoveryAST = true; /// If true, turn on the `-frecovery-ast-type` clang flag. bool PreserveRecoveryASTType = false; @@ -354,7 +354,7 @@ class ClangdServer { bool SuggestMissingIncludes = false; // If true, preserve expressions in AST for broken code. - bool BuildRecoveryAST = false; + bool BuildRecoveryAST = true; // If true, preserve the type for recovery AST. bool PreserveRecoveryASTType = false; diff --git a/clang-tools-extra/clangd/tool/ClangdMain.cpp b/clang-tools-extra/clangd/tool/ClangdMain.cpp index 331dd1121d17..34d72a9783d6 100644 --- a/clang-tools-extra/clangd/tool/ClangdMain.cpp +++ b/clang-tools-extra/clangd/tool/ClangdMain.cpp @@ -281,11 +281,10 @@ opt<bool> CrossFileRename{ opt<bool> RecoveryAST{ "recovery-ast", cat(Features), - desc("Preserve expressions in AST for broken code (C++ only). Note that " - "this feature is experimental and may lead to crashes"), - init(false), - Hidden, + desc("Preserve expressions in AST for broken code (C++ only)."), + init(ClangdServer::Options().BuildRecoveryAST), }; + opt<bool> RecoveryASTType{ "recovery-ast-type", cat(Features), _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
