njames93 added inline comments.
Herald added a subscriber: arphaman.

================
Comment at: clang-tidy/tool/ClangTidyMain.cpp:362
+                 << Plural << "\n";
+    return WErrorCount;
+  }
----------------
Was there any specific reason for returning the error count instead of 
returning 1. It results in undefined behaviour on POSIX shells if a value is 
returned outside the range of 0<=n<=255. See 
https://bugs.llvm.org/show_bug.cgi?id=46305


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D15528/new/

https://reviews.llvm.org/D15528



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D15528: Teach clang-t... Nathan James via Phabricator via cfe-commits

Reply via email to