martong added a comment.

In D72705#2041779 <https://reviews.llvm.org/D72705#2041779>, @balazske wrote:

> I can make comparisons if more functions are added to the checker, `fputs` 
> only is not sufficient.


Yes, you cannot measure just with fputs, similar thing happened to me with 
StdCLibraryFunctions, thus I had to add many many more functions to be able to 
measure.
So, what if you had a private branch where you have several functions other 
than fputs added. If I were you I'd search (count) for the interesting 
functions (the ones mentioned in ERR33) in one of the open projects: e.g. tmux. 
If there is reasonable number of such functions, then I'd sort these functions 
by the number of calls on them. I'd implement the ones with the highest count 
and smallest effort needed. Then we'd have some numbers to bolster this 
direction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72705/new/

https://reviews.llvm.org/D72705



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to