baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added a comment.
This check was made upon user request. I think it is a good base that can later
be extended also for the negated cases (where the code inside the inner `if`
never executes). That case is even more suspicious. I put it into `misc`
because it is not such a bug that it should go into `bugprone` but rather a
suspicious thing. The type of the bug is somewhat similar to the bugs detected
by `misc-redundant-expression` so I think `misc` is the best place also for
this one.
================
Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:135
`cppcoreguidelines-avoid-goto <cppcoreguidelines-avoid-goto.html>`_,
+ `cppcoreguidelines-avoid-non-const-global-variables
<cppcoreguidelines-avoid-non-const-global-variables.html>`_,
`cppcoreguidelines-init-variables
<cppcoreguidelines-init-variables.html>`_, "Yes"
----------------
What are these changes? I surely did not make them? Maybe the check adder
Python script?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81272/new/
https://reviews.llvm.org/D81272
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
