hokein added inline comments.
================
Comment at: clang/include/clang/AST/Expr.h:6158
public:
- TypoExpr(QualType T) : Expr(TypoExprClass, T, VK_LValue, OK_Ordinary) {
+ TypoExpr(QualType T, SourceLocation Start, SourceLocation End)
+ : Expr(TypoExprClass, T, VK_LValue, OK_Ordinary), Start(Start), End(End)
{
----------------
sammccall wrote:
> can we have Start != End in practice?
>
> Looking at DeclarationNameInfo::getEndLocPrivate(), it seems like this only
> happens in operators, literal-operators, conversions,
> constructors/destructors.
>
> If these don't actually support typo correction maybe we should just use one
> location?
ah, yes, I missed this.
typo correction only supports identifiers, so Start and End are always the same.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81008/new/
https://reviews.llvm.org/D81008
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
