steveire added a comment. In D80961#2067638 <https://reviews.llvm.org/D80961#2067638>, @gribozavr2 wrote:
> If IgnoreUnlessSpelledInSource is indeed for novice users (and not to be > strictly interpreted as "it does what it says") we should think about whether > it more useful to ignore instantiations or to match in instantiations. Tools should generally follow the Hippocratic: First do no harm. As I demonstrated, simple tools currently accidentally make unintended and incorrect changes to code. That is wrong. Do you have a standing objection to this being changed? I can't really work on this if I know or assume that you're going to prevent it going in (ever or for a significant time which results in this being harder than it should be). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
