efriedma accepted this revision.
efriedma added a comment.

LGTM.  For non-Android, I think it makes sense to align with gcc as much as 
possible.

> This is mostly
>  for legacy/compatibility reasons, and the 2019 Q4 revision of the ARM
>  AAPCS looks to standardize r11 as the frame pointer for aarch32, though
>  this is not yet implemented in LLVM.

It's also really expensive to use r11 as a frame pointer in Thumb1.  I guess 
it's not impossible, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80828/new/

https://reviews.llvm.org/D80828



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to