tmsriram marked an inline comment as done. tmsriram added a comment. In D68049#2066937 <https://reviews.llvm.org/D68049#2066937>, @MaskRay wrote:
> LLD side changes look good. Are you waiting on an explicit approval from > @rmisth ? Yes. ================ Comment at: lld/ELF/LTO.cpp:79 // Check if basic block sections must be used. // Allowed values for --lto-basicblock-sections are "all", "labels", // "<file name specifying basic block ids>", or none. This is the equivalent ---------------- MaskRay wrote: > `--lto-basic-block-sections` > > I think it should be fine updating it here, and probably preferable, since > you already touched some related LLD code. It does not affect any tests. (You > did not add any tests for `--lto-basicblock-sections` in the original LLD > patch.) Yes, I intend to clean this up and the llc option in a separate cleanup patch so that this doesn't get too complicated. Is that alright? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
