This revision was automatically updated to reflect the committed changes.
Closed by commit rL264251: [clang-tidy] misc-assign-operator-signature checker
checks return value of… (authored by xazax).
Changed prior to commit:
http://reviews.llvm.org/D18264?vs=51521&id=51527#toc
Repository:
rL LLVM
http://reviews.llvm.org/D18264
Files:
clang-tools-extra/trunk/clang-tidy/misc/AssignOperatorSignatureCheck.cpp
clang-tools-extra/trunk/test/clang-tidy/misc-assign-operator-signature.cpp
Index: clang-tools-extra/trunk/clang-tidy/misc/AssignOperatorSignatureCheck.cpp
===================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/AssignOperatorSignatureCheck.cpp
+++ clang-tools-extra/trunk/clang-tidy/misc/AssignOperatorSignatureCheck.cpp
@@ -31,14 +31,16 @@
const auto IsSelf = qualType(
anyOf(hasDeclaration(equalsBoundNode("class")),
referenceType(pointee(hasDeclaration(equalsBoundNode("class"))))));
- const auto IsSelfAssign =
+ const auto IsAssign =
cxxMethodDecl(unless(anyOf(isDeleted(), isPrivate(), isImplicit())),
- hasName("operator="), ofClass(recordDecl().bind("class")),
- hasParameter(0, parmVarDecl(hasType(IsSelf))))
+ hasName("operator="), ofClass(recordDecl().bind("class")))
+ .bind("method");
+ const auto IsSelfAssign =
+ cxxMethodDecl(IsAssign, hasParameter(0, parmVarDecl(hasType(IsSelf))))
.bind("method");
Finder->addMatcher(
- cxxMethodDecl(IsSelfAssign,
unless(HasGoodReturnType)).bind("ReturnType"),
+ cxxMethodDecl(IsAssign, unless(HasGoodReturnType)).bind("ReturnType"),
this);
const auto BadSelf = referenceType(
@@ -58,14 +60,13 @@
void AssignOperatorSignatureCheck::check(
const MatchFinder::MatchResult &Result) {
- const auto* Method = Result.Nodes.getNodeAs<CXXMethodDecl>("method");
+ const auto *Method = Result.Nodes.getNodeAs<CXXMethodDecl>("method");
std::string Name = Method->getParent()->getName();
static const char *const Messages[][2] = {
{"ReturnType", "operator=() should return '%0&'"},
{"ArgumentType", "operator=() should take '%0 const&', '%0&&' or '%0'"},
- {"cv", "operator=() should not be marked '%1'"}
- };
+ {"cv", "operator=() should not be marked '%1'"}};
for (const auto &Message : Messages) {
if (Result.Nodes.getNodeAs<Decl>(Message[0]))
Index:
clang-tools-extra/trunk/test/clang-tidy/misc-assign-operator-signature.cpp
===================================================================
--- clang-tools-extra/trunk/test/clang-tidy/misc-assign-operator-signature.cpp
+++ clang-tools-extra/trunk/test/clang-tidy/misc-assign-operator-signature.cpp
@@ -18,6 +18,8 @@
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: operator=() should return
'BadReturn&' [misc-assign-operator-signature]
const BadReturn& operator=(BadReturn&&);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: operator=() should return 'Bad
+ void operator=(int);
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: operator=() should return 'Bad
};
struct BadReturn2 {
BadReturn2&& operator=(const BadReturn2&);
Index: clang-tools-extra/trunk/clang-tidy/misc/AssignOperatorSignatureCheck.cpp
===================================================================
--- clang-tools-extra/trunk/clang-tidy/misc/AssignOperatorSignatureCheck.cpp
+++ clang-tools-extra/trunk/clang-tidy/misc/AssignOperatorSignatureCheck.cpp
@@ -31,14 +31,16 @@
const auto IsSelf = qualType(
anyOf(hasDeclaration(equalsBoundNode("class")),
referenceType(pointee(hasDeclaration(equalsBoundNode("class"))))));
- const auto IsSelfAssign =
+ const auto IsAssign =
cxxMethodDecl(unless(anyOf(isDeleted(), isPrivate(), isImplicit())),
- hasName("operator="), ofClass(recordDecl().bind("class")),
- hasParameter(0, parmVarDecl(hasType(IsSelf))))
+ hasName("operator="), ofClass(recordDecl().bind("class")))
+ .bind("method");
+ const auto IsSelfAssign =
+ cxxMethodDecl(IsAssign, hasParameter(0, parmVarDecl(hasType(IsSelf))))
.bind("method");
Finder->addMatcher(
- cxxMethodDecl(IsSelfAssign, unless(HasGoodReturnType)).bind("ReturnType"),
+ cxxMethodDecl(IsAssign, unless(HasGoodReturnType)).bind("ReturnType"),
this);
const auto BadSelf = referenceType(
@@ -58,14 +60,13 @@
void AssignOperatorSignatureCheck::check(
const MatchFinder::MatchResult &Result) {
- const auto* Method = Result.Nodes.getNodeAs<CXXMethodDecl>("method");
+ const auto *Method = Result.Nodes.getNodeAs<CXXMethodDecl>("method");
std::string Name = Method->getParent()->getName();
static const char *const Messages[][2] = {
{"ReturnType", "operator=() should return '%0&'"},
{"ArgumentType", "operator=() should take '%0 const&', '%0&&' or '%0'"},
- {"cv", "operator=() should not be marked '%1'"}
- };
+ {"cv", "operator=() should not be marked '%1'"}};
for (const auto &Message : Messages) {
if (Result.Nodes.getNodeAs<Decl>(Message[0]))
Index: clang-tools-extra/trunk/test/clang-tidy/misc-assign-operator-signature.cpp
===================================================================
--- clang-tools-extra/trunk/test/clang-tidy/misc-assign-operator-signature.cpp
+++ clang-tools-extra/trunk/test/clang-tidy/misc-assign-operator-signature.cpp
@@ -18,6 +18,8 @@
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: operator=() should return 'BadReturn&' [misc-assign-operator-signature]
const BadReturn& operator=(BadReturn&&);
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: operator=() should return 'Bad
+ void operator=(int);
+ // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: operator=() should return 'Bad
};
struct BadReturn2 {
BadReturn2&& operator=(const BadReturn2&);
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
