rjmccall added a comment. > Yes at the moment I think we want to limit element wise > accesses/modifications to go through the access operator only, to guarantee > we can rely on the vector forms in codegen. > > Additionally I think at least initially we want to avoid handing out pointers > to elements, as it may be tempting to use for pointer-based accesses to > subsequent elements. I am a bit worried that allowing that would muddy the > waters a bit and may lead to interpreting matrix types as similar to arrays, > instead of single value types with restricted element access. Does that make > sense?
It does make sense, although it does make it very important that code generation narrows the relevant particular load/extractvalue and load/insertvalue/store sequences, or else performance and code size will be completely unacceptable for large matrices. The test changes in the other patch look great, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76791/new/ https://reviews.llvm.org/D76791 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
