MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment.
Would something like this be easier to read? F12027905: image.png <https://reviews.llvm.org/F12027905> ================ Comment at: clang/docs/tools/generate_formatted_state.py:52 + path = os.path.relpath(root, LLVM_DIR) + if "/test/" in path: + continue ---------------- curdeius wrote: > That doesn't work on Windows because of slashes. You doesn't skip `unittests` > (present at least in clang and llvm). So unit tests is something that I I think needs to be clang-formatted, this is because often we are actively editing in there, (I use format on save) and so having clean tests is super important The tests directories normally have 100's of small snippets of code and some may even be testing unformatted code deliberately, these files are often made once and not continuously edited, (whilst it would be good to have them clean, I wanted to give ourselves a fighting chance!) Point taken about Windows, whilst I develop myself on Windows I use cygwin which is why it probably worked. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80627/new/ https://reviews.llvm.org/D80627 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
