dblaikie added a comment. In D80369#2057874 <https://reviews.llvm.org/D80369#2057874>, @aprantl wrote:
> > The declaration subprograms are in the retained types list - but when > > retained types are emitted, only types in the retained types list are used, > > the subprograms (and the types they only indirectly reference) are ignored. > > So adding the subprogram nodes to retained types has no effect? So far as I can tell. The only use (other than serializing and deserializing) of retained types seems to be here: https://github.com/llvm-mirror/llvm/blob/master/lib/CodeGen/AsmPrinter/DwarfDebug.cpp#L882 which filter only the types in the retained types list. I'd say, even, that the retained types list should probably be only types (verifier check?) unless/until we have a use case otherwise. (& if anyone wants to merge the enums list with the retained types list, that'd be a nice cleanup too). > That's good to know. I think we can remove the code then, as long as the > existing tests aren't affected. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80369/new/ https://reviews.llvm.org/D80369 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
