tdl-g marked 4 inline comments as done.
tdl-g added a comment.
Thanks again, addressed all comments.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/abseil-string-find-str-contains.cpp:2
+// RUN: %check_clang_tidy %s abseil-string-find-str-contains %t -- \
+// RUN: -config="{CheckOptions: []}"
+
----------------
tdl-g wrote:
> ymandel wrote:
> > I'm not sure what's standard practice, but consider whether its worth
> > adding another test file that tests the check options. It wouldn't have to
> > be comprehensive like this one, just some basic tests that the options are
> > being honored.
> I'm open to it, but note that two of the three options (IncludeStyle,
> inherited from TransformerClangTidy) and AbseilStringsMatchHeader, only
> manifest in the header-inclusion.
>
> So if I had a separate test it would be easy to confirm that
> StringLikeClasses was being honored. But I'm not sure how I'd confirm that
> IncludeStyle or AbseilStringsMatchHeader are being honored. Suggestions?
Discussed with ymandel offline, we'll add more option-specific tests when we
clean up transformer's options handling.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80023/new/
https://reviews.llvm.org/D80023
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
