rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/include/clang/AST/Type.h:1069
+ /// qualifiers.
+ bool isAddressSpaceOverlapping(const QualType &T) const {
+ Qualifiers Q = getQualifiers();
----------------
bader wrote:
> rjmccall wrote:
> > It's idiomatic to take `QualType` by value rather than `const &`.
> >
> > Can you rewrite the `PointerType` method to delegate to this? Assuming it
> > isn't completely dead, that is.
> It isn't completely dead, but there were just a few uses of the `PointerType`
> method, so I've updated all of them to avoid code duplication in two classes.
Even better, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80317/new/
https://reviews.llvm.org/D80317
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
