fpetrogalli accepted this revision.
fpetrogalli added a comment.
This revision is now accepted and ready to land.
LGTM, it would be great if you could address the two comments I added, before
submitting.
================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10775
- llvm::VectorType *MaskTy = llvm::VectorType::get(CGF.Builder.getInt1Ty(),
- cast<IntegerType>(Mask->getType())->getBitWidth());
+ llvm::VectorType *MaskTy = llvm::FixedVectorType::get(
+ CGF.Builder.getInt1Ty(),
----------------
`auto`?
================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4670
if (!CGF.CGM.getCodeGenOpts().PreserveVec3Type) {
- auto Vec4Ty = llvm::VectorType::get(
+ auto Vec4Ty = llvm::FixedVectorType::get(
cast<llvm::VectorType>(DstTy)->getElementType(), 4);
----------------
`auto *`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80323/new/
https://reviews.llvm.org/D80323
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
