dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land.
otherwise LGTM ================ Comment at: clang/docs/DiagnosticsReference.rst:14018 ++-----------------------------------------------------------------------------------------------------------------------------------+ +|:warning:`warning:` |nbsp| :diagtext:`dynamic exception specifications with types are currently ignored in wasm exception handling`| ++-----------------------------------------------------------------------------------------------------------------------------------+ ---------------- I think it's not actually necessary to change the text of the warning. Since the warning is about an exception handling language feature, I think adding "exception handling" on the end doesn't make it any more clear and sounds a little redundant to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/ https://reviews.llvm.org/D80362 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
