Szelethus marked 4 inline comments as done.
Szelethus added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:66
+ // convert these to actual checkers.
+ enum CheckKind {
+ CK_FunctionPointer,
----------------
martong wrote:
> So, we are not going to have subcheckers, rather options, okay. Perhaps the
> comment would be more appropriate to be in `Checkers.td`? (If we can put
> comments there.)
I prefer it here, `Checkers.td` is a rarely visited file, and the comments in
the test cases all point here where the majority of the work has to be done.
Which still isn't much, but this is the bit we should not screw up.
Btw we can totally put comments there, as seen here: D78120
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77866/new/
https://reviews.llvm.org/D77866
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
