jasonliu added inline comments.
================ Comment at: clang/include/clang/AST/RecordLayout.h:74 + /// The maximum allowed field alignment. This is set by #pragma pack. + CharUnits MaxFieldAlignment; + ---------------- efriedma wrote: > If we have to keep around extra data anyway, probably better to add a field > for the preferred alignment, so we can keep the preferred alignment handling > together. We could get the MaxFieldAlignment in the same way ItaniumRecordLayoutBuilder::InitializeLayout get. Do we need to keep an extra data? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
