sammccall accepted this revision. sammccall added a subscriber: rsmith. sammccall added a comment. This revision is now accepted and ready to land.
Sorry for stalling this. This is a sad situation, the API is actively misleading about the invariants. Even the new API isn't very safe: getParent() isn't a great name if it only works on *some* things that have parents. @rsmith any opinion on what we should do with this one? Would a rename to `getParentRecord()` help much? Something more invasive? Approving since this is already a bit better and we can fix a crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79627/new/ https://reviews.llvm.org/D79627 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
